initial work to reconcile devices from launcher pods #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
backend changes related to: rancher/dashboard#11399 |
This was referenced Sep 16, 2024
Yu-Jack
approved these changes
Sep 23, 2024
ibrokethecloud
force-pushed
the
plugin-device-tracking
branch
from
6b03b33
to
b4488ba
Compare
ibrokethecloud
added a commit
to ibrokethecloud/harvester-charts
that referenced
this pull request
Sep 23, 2024
ibrokethecloud
force-pushed
the
plugin-device-tracking
branch
from
b4488ba
to
46ee5eb
Compare
WebberHuang1118
approved these changes
Oct 2, 2024
initial work to reconcile devices from launcher pods refactor vmi reconcile to pass codefactor check refactor code and change validation logic to use new annotations modified vmi/vm reconcile to also update vm with correct device names based on vgpu annotation when VM is stopped include pr review feedback fine tune logic for removing duplicates from allocation annotation
ibrokethecloud
force-pushed
the
plugin-device-tracking
branch
from
b12b815
to
70f68d2
Compare
ibrokethecloud
added a commit
to harvester/charts
that referenced
this pull request
Oct 6, 2024
ibrokethecloud
added a commit
to ibrokethecloud/harvester-charts
that referenced
this pull request
Oct 7, 2024
ibrokethecloud
added a commit
to harvester/charts
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Rancher allows provisioning of downstream clusters to leverage vGPUs.
When used with a machine deployment of more than 1 node, the actual gpu allocated is different from name specified since kubevirt leverages the DeviceName field to calculate launcher pod resource requirements, which are then subsequently used by schedular to identify correct nodes.
Since the actual name is not really used for device allocation, any random string can be used and this makes it difficult to track vGPU allocation in the cluster.
Solution:
PR introduces a minor change to leverage pod environment variables being set by the device plugin during the ContainerAllocateResponse. The additional vmi controller execs into the launcher pod to identify the ID set for resource, and subsequently map it to the GPU/Hostdevice resources. Once the devices are identify an annotation is set on the VM to provide info about actual device from a pool of devices passed through to the VM
For example for a host device this looks as follows:
For GPU devices ithis looks as follows:
When a VM is shutdown the annotation is used to replace
namefor vGPU or host devices with actual device names from the deviceAllocationDetails annotation. This ensures that the VM can be edited and devices can be removed from Harvester UI post provisioning.Related Issue:
Test plan: